enhancement: connection.closed attribute to actually become a property that dynamically probes the current cxn state

Master does not compile:

x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -DPSYCOPG_DEFAULT_PYDATETIME=1 -DPSYCOPG_VERSION="2.6.dev0 (dt dec pq3 ext)" -DPG_VERSION_HEX=0x09010C -DPG_VERSION_HEX=0x09010C -I/usr/include/python2.7 -I. -I/usr/include/postgresql -I/usr/include/postgresql/9.1/server -c psycopg/connection_type.c -o build/temp.linux-x86_64-2.7/psycopg/connection_type.o -Wdeclaration-after-statement -Wdeclaration-after-statement

psycopg/connection_type.c:1037:13: error: ‘psyco_conn_get_exception’ undeclared here (not in a function)

     { #exc, psyco_conn_get_exception, NULL, exc ## _doc, &exc }

             ^

psycopg/connection_type.c:1041:5: note: in expansion of macro ‘EXCEPTION_GETTER’

     EXCEPTION_GETTER(Error),

     ^

error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

It does for me. psyco_conn_get_exception is declared in the same file at line 835 in current master.

I knew that :)

Don't know what is the problem. Just run

pip install -e git+https://github.com/dvarrazzo/psycopg.git#egg=psycopg2

Simple pip install psycopg2 works flawlessly.

I guess I'll wait for official 2.5.3.

Thanks for fixing this issue!

Zaar

Uhm... I was going to reply you that you can pip-install a project from a branch: you could have tested my branch with:

pip install -e git+https://github.com/dvarrazzo/psycopg.git@connection-closed#egg=psycopg2

but actually I tried that... and triggered your bug. So I'll check how to fix it.

gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -DHAVE_MXDATETIME=1 -DPSYCOPG_DEFAULT_PYDATETIME=1 -DPSYCOPG_VERSION="2.5.3.dev0 (dt dec mx pq3 ext)" -DPG_VERSION_HEX=0x090303 -DPG_VERSION_HEX=0x090303 -I/usr/include/python2.7/mx -I/usr/include/python2.7 -I. -I/usr/include/postgresql -I/usr/include/postgresql/9.3/server -c psycopg/connection_type.c -o build/temp.linux-x86_64-2.7/psycopg/connection_type.o -Wdeclaration-after-statement -Wdeclaration-after-statement

psycopg/connection_type.c:1039:5: error: ‘psyco_conn_get_exception’ undeclared here (not in a function)

error: command 'gcc' failed with exit status 1

first attempt to reproduce the issue failed: "make" and "python setup.py build" in the checkout dir work. mmm...

The difference is that the failing version is building without:

-DPSYCOPG_EXTENSIONS=1 -DPSYCOPG_NEW_BOOLEAN=1 -DHAVE_PQFREEMEM=1

and we haven't really tested using no PSYCOPG_EXTENSIONS in this century. I wonder why the setup.py/.cfg is not doing what expected: that's new.

For what I can see it's a pip bug which doesn't take in consideration the setup.cfg. I've reported the issue at https://github.com/pypa/pip/issues/1630

Zaar, if you can help me testing, just check out psycopg from the branch in github and install it with a python setup.py install. That should just work.

Daniele,
Don't know if this is related but when opening a connection I do the following.

class Conn(psycopg2.extensions.connection):
    def __init__(self, dsnStr):
        try:
            super(Conn, self).__init__(dsnStr)
            print "Connection using < %s > is successful" % self.dsn
        except:
            self.close() # explicit close otherwise 'connection.closed' reads as open still
            print "Connection using < %s > failed" % self.dsn
    
    # bunch of db utility methods here
    
conn = Conn('user=dpostgres password=fght98 host=localhost')
if conn.closed == 0:
    # Do something with the db
else:
    # Ask user to correct dsn parameters and try again

If the connection attempt fails, the exception is caught.... but the closed attribute
has already been set to 0 which should be 1 at this point. That's why I do a close().

Maybe I'm doing it wrong and should not attempt to do anything with the class if
the connection fails and just return False; but having access to the dsn attribute is a good thing.

Cheers
:)

Yes, I'd say it's related. It's a sort of corner case but I'll try to iron out that too for next release.

On the same subject,

connection.dsn

connection.dsn

Fixed the problems with dsn and closed in connection subclasses. Please open a different issue if you have something else to report :)

Open ticket #204 pip fails to build psycopg from url to deal with the pip -e problem