Psycopg psycopg

Comments and changes to this ticket

• 

  Daniele Varrazzo March 15th, 2013 @ 11:37 AM

  Thank you, I'll look into the issue.

  Out of curiosity, wouldn't have been the same to add on top of the failing tests something like:

  if postgres_version >= 9.3:
      set client_min_message = debug1
  

  and keep the tests unchanged?

• You flagged this item as spam.
  

  Catalin Iacob March 15th, 2013 @ 04:42 PM

  They couldn't stay completely unchanged. With debug1 I get an extra message (building index...) so at least the test that counts the notices would need changes:

  psycopg2_test=# set client_min_messages = debug1;
  SET
  psycopg2_test=# create temp table abc2 (id serial primary key);
  DEBUG:  CREATE TABLE will create implicit sequence "abc2_id_seq" for serial column "abc2.id"
  DEBUG:  CREATE TABLE / PRIMARY KEY will create implicit index "abc2_pkey" for table "abc2"
  DEBUG:  building index "abc2_pkey" on table "abc2"
  CREATE TABLE
  

• 

  Daniele Varrazzo March 15th, 2013 @ 04:48 PM

  • State changed from “new” to “open”

  I see, thank you for the tests. I'll commit your test suite patch for the next release.

• You flagged this item as spam.
  

  Catalin Iacob March 15th, 2013 @ 05:06 PM

  Actually, I checked instead of just reasoning about it and I was wrong, the alternative also works.

  The notices get counted only for tables that don't have primary keys so there is no "building index..." message that gets in the way.

  So the attached alternative patch also passes all tests.

• You flagged this item as spam.
  

  Catalin Iacob March 15th, 2013 @ 05:13 PM

  Correct patch now. I attached the wrong file in previous message (and deleted it now to avoid confusion).

  • 0001-Fix-tests-for-Postgres-93-bump-message-verbosity.patch 2.6 KB
• 

  Daniele Varrazzo March 15th, 2013 @ 05:21 PM

  ♥

• 

  Daniele Varrazzo March 16th, 2013 @ 12:56 AM

  • State changed from “open” to “resolved”

  Pushed to devel, thank you.